Update example to use context manager#2134
Closed
ranmocy wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Thank you for your contribution. We learned over the past few years while context managers are great to use, that the community often miss-understands them, so we prefer keeping it as it is. |
Author
|
@mxschmitt Thanks for replying. Is there any related thread or docs talking about the common mistakes? I'm very curious to learn about them. |
Contributor
|
e.g. think about that you use a context manager to get a page, you use it after the expect and wonder, why is it closed? We saw this is a popular pattern which confused users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sure resources are released. And less lines of code.
These usages are tested under:
https://github.com/microsoft/playwright-python/blob/59369fe126f49c10597d5c9099840bdc8ccdcf15/tests/sync/test_context_manager.py
https://github.com/microsoft/playwright-python/blob/59369fe126f49c10597d5c9099840bdc8ccdcf15/tests/async/test_context_manager.py